New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2912: Convert resource.js to ts and add types #8947
Conversation
@@ -41,7 +41,7 @@ export const removeTrigger = async (values: RemoveTriggerFormValues, pipeline: P | |||
updatableEventListeners.map((eventListener) => | |||
k8sPatch(EventListenerModel, eventListener, [ | |||
{ | |||
opt: 'replace', | |||
op: 'replace', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewballantyne Can you help verify this change?
I'm not sure what the default is if op
is missing. add
might actually be better since it handles the case where spec.triggers
is missing, but will replace it if present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think spec.triggers
is a required field. (cc @karthikjeeyar) but yeah, this looks okay, still removes the trigger 🙂 Not sure how this was missed before. Guess if it works people don't look too closely lol.
@@ -112,7 +112,7 @@ export const watchK8sObject = ( | |||
|
|||
const { subprotocols } = getState().UI.get('impersonate', {}); | |||
|
|||
WS[id] = k8sWatch(k8sType, { ...query, subprotocols }).onbulkmessage((events) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a bug too. subprotocols
were never passed properly to websocket
@spadgett PTAL |
45c2e7f
to
fbf4553
Compare
/retest |
b3f80bd
to
74e7301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Thank you! Do you mind opening a Bugzilla for the bugs in the ceph plugin that you fixed? We should have QE validate.
/retest |
/test kubevirt-plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
just marking |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jelkosz, rawagner, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
No description provided.