Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-5910-update kafka event source feature file #9092

Merged
merged 1 commit into from Jun 2, 2021
Merged

ODC-5910-update kafka event source feature file #9092

merged 1 commit into from Jun 2, 2021

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Jun 1, 2021

Fixes
https://issues.redhat.com/browse/ODC-5910

Analysis / Root cause:
gherkin scripts are missing with given conditions

Solution Description:
gherkin script for kafka source updated

Browser conformance:
Chrome

Dependencies
#9090 - Merged

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@makambalaji makambalaji changed the title [WIP] ODC-5910-update kafka event source feature file ODC-5910-update kafka event source feature file Jun 2, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2021
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 502fb0c into openshift:master Jun 2, 2021
@spadgett spadgett added this to the v4.8 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants