Explicitly touch pipeline builder task fields when workspaces are changed #9130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rottencandy Even without this change I see the errors showing up correctly in the task sidbebar, I have verified it in the cluster latest build 4.8.0-0.nightly-2021-06-06-164529. cc: @jerolimov @andrewballantyne Edit: I have observed the above while creating a pipeline, but the while editing a Pipeline I see the issue. Thanks @rottencandy for this fix. |
frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/hooks.ts
Outdated
Show resolved
Hide resolved
rottencandy
force-pushed
the
fix/pipeline-formik-touch
branch
from
1d072a3
to
ef17f90
Compare
|
/lgtm |
jerolimov
reviewed
Jun 8, 2021
frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/hooks.ts
Outdated
Show resolved
Hide resolved
rottencandy
force-pushed
the
fix/pipeline-formik-touch
branch
from
ef17f90
to
7c56e64
Compare
andrewballantyne
approved these changes
Jun 8, 2021
openshift-ci
bot
added
the
approved
jerolimov
approved these changes
Jun 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jerolimov, karthikjeeyar, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-5894
Analysis / Root cause:
Formik fields do not echo errors unless they are touched.
Solution Description:
Use a hook to explicitly touch all task fields so they echo errors when dependent fields are changed.
Screen shots / Gifs for design review:
0.mp4
Unit test coverage report:
(unchanged)
Test setup:
Browser conformance: