Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1961391: Textual Updates #9333

Merged
merged 1 commit into from Jun 24, 2021
Merged

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jun 23, 2021

Fixed the following bugs as reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1961391#c10

  • "Caching is a policy that creates local copies of the data. It saves the copies locally to improve performance for frequently accessed data. Each cached copy has a TTL and is verified against the hub. Each non-read operation(upload, overwrite, delete) is performed on the hub" - There should be a space before the parenthesis
  • "And"/comma separated list - The concern here is that we're not making the full context available. Not all languages use comma-separated lists (or that they may use different styles of commas). The translators have been having trouble with the out-of-context "and" also.

Modal now

ss

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@rexagod: This pull request references Bugzilla bug 1961391, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @rebeccaalpert

In response to this:

Bug 1961391: Textual Updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 23, 2021
@rexagod rexagod marked this pull request as draft June 23, 2021 20:20
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2021
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jun 23, 2021
@rexagod rexagod marked this pull request as ready for review June 23, 2021 20:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@rexagod: This pull request references Bugzilla bug 1961391, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @rebeccaalpert

In response to this:

Bug 1961391: Textual Updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rexagod
Copy link
Member Author

rexagod commented Jun 23, 2021

/cc @afreen23

@openshift-ci openshift-ci bot requested a review from afreen23 June 23, 2021 20:51
@rexagod
Copy link
Member Author

rexagod commented Jun 24, 2021

Fixing tests.

@afreen23
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2021
@afreen23
Copy link
Contributor

tests are failing due to -

AssertionError: Missing i18n key "<0><0>{{poolName}}</0> cannot be deleted. When a pool is bounded to PVC it cannot be deleted. Please detach all the resources from StorageClass(es):</0><1><0><0>testing-sc</0></0></1>" in namespace "ceph-storage-plugin" and language "en.": expected false to be true

/lgtm cancel

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2021
@rexagod
Copy link
Member Author

rexagod commented Jun 24, 2021

/retest

@afreen23
Copy link
Contributor

squash commits.

Fixed the following bugs as reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1961391#c10

* "Caching is a policy that creates local copies of the data. It saves the copies locally to improve performance for frequently accessed data. Each cached copy has a TTL and is verified against the hub. Each non-read operation(upload, overwrite, delete) is performed on the hub" - There should be a space before the parenthesis
* "And"/comma separated list - The concern here is that we're not making the full context available. Not all languages use comma-separated lists (or that they may use different styles of commas). The translators have been having trouble with the out-of-context "and" also.
@rexagod
Copy link
Member Author

rexagod commented Jun 24, 2021

/test e2e-gcp-console

@afreen23
Copy link
Contributor

/lgtm
Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9d92ae0 into openshift:master Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@rexagod: All pull requests linked via external trackers have merged:

Bugzilla bug 1961391 has been moved to the MODIFIED state.

In response to this:

Bug 1961391: Textual Updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants