Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1982150: Add a TechPreviewBadge for Multus #9511

Merged
merged 1 commit into from Jul 17, 2021
Merged

Bug 1982150: Add a TechPreviewBadge for Multus #9511

merged 1 commit into from Jul 17, 2021

Conversation

SanjalKatiyar
Copy link
Contributor

Screenshot from 2021-07-14 16-52-38

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@SanjalKatiyar: This pull request references Bugzilla bug 1982150, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1982150: Add a TechPreviewBadge for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from afreen23 and bipuladh July 14, 2021 14:51
@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Jul 14, 2021
bipuladh
bipuladh reviewed Jul 15, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-wizard/_configure.scss
@@ -14,3 +14,7 @@
.ceph__multus-dropdown-button {
min-width: 18em;
}

.ceph__multus-tech-preview-badge--margin {
margin: calc(var(--pf-global--spacer--xs) * -1) 0 0 calc(var(--pf-global--spacer--sm) * -2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why negative margins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-07-14 16-14-01

This is how badge was looking earlier, applied negative margin to top and left so that badge is now aligned with the multus radio button.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3be8fe3 into openshift:master Jul 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2021

@SanjalKatiyar: All pull requests linked via external trackers have merged:

Bugzilla bug 1982150 has been moved to the MODIFIED state.

In response to this:

Bug 1982150: Add a TechPreviewBadge for Multus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

@SanjalKatiyar: new pull request created: #9539

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SanjalKatiyar @bipuladh @openshift-bot @openshift-cherrypick-robot @spadgett @openshift-merge-robot