Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1984102: Switch Cypress OLM tests to use supported Red Hat operators #9560

Merged
merged 3 commits into from Nov 1, 2021
Merged

[release-4.8] Bug 1984102: Switch Cypress OLM tests to use supported Red Hat operators #9560

merged 3 commits into from Nov 1, 2021

Conversation

dtaylor113
Copy link
Contributor

@dtaylor113 dtaylor113 commented Jul 20, 2021 •
edited

Backports of #9420 & #9681

@dtaylor113
single-install test using RH CodeReady Workspaces Operator
e572e2d 
# Conflicts:
#	frontend/packages/integration-tests-cypress/views/list-page.ts
#	frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-global.spec.ts
#	frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/operator-install-single-namespace.spec.ts
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 20, 2021
@openshift-ci openshift-ci bot added component/olm Related to OLM kind/cypress Related to Cypress e2e integration testing bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 20, 2021
@openshift-ci openshift-ci bot requested a review from yapei July 20, 2021 17:25
@openshift openshift deleted a comment from openshift-ci bot Jul 20, 2021
@openshift openshift deleted a comment from openshift-ci bot Jul 20, 2021
@dtaylor113 dtaylor113 mentioned this pull request Jul 21, 2021
Merged
@openshift openshift deleted a comment from openshift-ci bot Jul 21, 2021
@openshift openshift deleted a comment from openshift-ci bot Jul 21, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 23, 2021
spadgett
spadgett approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@yapei
Copy link
Contributor

yapei commented Jul 26, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 26, 2021
@yapei
Copy link
Contributor

yapei commented Jul 26, 2021

/lgtm

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@dtaylor113
Copy link
Contributor Author

Hi @sdodson, @spadgett, and @kdoberst, just pushed a fix which updates test to match renamed operator property. This PR is now passing CI.

@sdodson
Copy link
Member

sdodson commented Oct 27, 2021

@dtaylor113 Just needs a fresh LGTM to merge now.

@dtaylor113
Copy link
Contributor Author

Hi @spadgett, pls give a "LGTM" tag if ready to merge, -thanks

jhadvig
jhadvig approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jhadvig, spadgett, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 281ec1e into openshift:release-4.8 Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

@dtaylor113: All pull requests linked via external trackers have merged:

Bugzilla bug 1984102 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1984102: Switch Cypress OLM tests to use supported Red Hat operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

@jhadvig jhadvig

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/olm Related to OLM kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dtaylor113 @yapei @openshift-bot @sdodson @mrunalp @spadgett @jhadvig @aravindhp @openshift-merge-robot