Bug 1972968: "Add Disk" button should be disabled in common template disks tab

[avivtur]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1972968

Analysis / Root cause:
the prop of isCommonTemplate was recived as null which caused the add disk button to be shown and enabled

Solution Description:
creating isCommonTemplate variable on VM disks table page to toggle the templates disks page to be disabled.
this also affects the add disk button for VMI disks that wasn't visable at all, it also made it visable and disabled.

Screen shots / Gifs for design review:
before:

after:

Signed-off-by: Aviv Turgeman aturgema@redhat.com

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 1972968, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1972968: "Add Disk" button should be disabled in common template disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 1972968, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1972968: "Add Disk" button should be disabled in common template disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gouyang]

/retest

[yaacov]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[avivtur]

/retest

[openshift-ci]

@avivtur: Bugzilla bug 1972968 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1972968: "Add Disk" button should be disabled in common template disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.