New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1991566: Disable protractor test in prow #9760
Bug 1991566: Disable protractor test in prow #9760
Conversation
@gouyang: An error was encountered searching for bug 1991566 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
could not unmarshal response body: invalid character '<' looking for beginning of value
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/lgtm |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 1991566, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
@spadgett PTAL |
@@ -35,7 +35,6 @@ | |||
"integration-tests/v2v/*.scenario.ts" | |||
], | |||
"kubevirt-gating": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove kubevirt-gating
altogether?
test-prow-e2e.sh
Outdated
@@ -66,7 +66,7 @@ export DBUS_SESSION_BUS_ADDRESS | |||
|
|||
SCENARIO="${1:-e2e}" | |||
|
|||
if [ "$SCENARIO" != "login" ] && [ "$SCENARIO" != "olmFull" ] && [ "$SCENARIO" != "ceph" ]; then | |||
if [ "$SCENARIO" != "login" ] && [ "$SCENARIO" != "olmFull" ] && [ "$SCENARIO" != "ceph" ] && [ "$SCENARIO" != "kubevirt-gating" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are enough items now that we should try to clean up this if statement. My bash isn't great, but I think this will work. (Please test.)
case $SCENARIO in
login|olmFull|ceph|kubevirt-gating) ;; # no protractor tests
*) CHROME_VERSION=$(google-chrome --version) ./test-protractor.sh "$SCENARIO";;
esac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (echo "login olmFull ceph kubevirt-gating" | grep -qvw "$SCENARIO") ; then
CHROME_VERSION=$(google-chrome --version) ./test-protractor.sh "$SCENARIO"
fi
may also work
bfd6afd
to
2fc3c14
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, spadgett, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@gouyang: All pull requests linked via external trackers have merged: Bugzilla bug 1991566 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.