New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1980531: step 3 additionalHelpActions 'HelpMenu' ConsoleLinks not translated #9811
Bug 1980531: step 3 additionalHelpActions 'HelpMenu' ConsoleLinks not translated #9811
Conversation
@kdoberst: This pull request references Bugzilla bug 1980531, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/integration-tests-cypress/tests/i18n/pseudolocalization.spec.ts
Outdated
Show resolved
Hide resolved
45c0846
to
5a1bf84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We usually can't use backticks in TFunctions because the parser can't pick them up, but you're doing an end run around it with the comments anyway. As long as it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kdoberst, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kdoberst: An error was encountered searching for external tracker bugs for bug 1980531 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
could not parse external identifier "openshift/console/pull/9385#pullrequestreview-702386658" as pull: invalid pull identifier: could not parse 9385#pullrequestreview-702386658 as number: strconv.Atoi: parsing "9385#pullrequestreview-702386658": invalid syntax
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@kdoberst: All pull requests linked via external trackers have merged: Bugzilla bug 1980531 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses Bug 1980531
In the help menu, the "Learning Portal" and "OpenShift Blog" links are brought into the console code so they can be translated.
This is the last of 3 PRs to complete the work for Bug 1980531.
Step 1 - Update tests
Step 2 - Remove links from operators
Step 3 - (this PR) Add links to console so they can be translated
Note: This PR replaces #9495