New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1988903: Kms details empty in only MCG deployment #9859
Conversation
afreen23
commented
Aug 24, 2021
•
edited
edited
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1988903
- updates request execution
- fixes the hidden token field in kms form
@afreen23: This pull request references Bugzilla bug 1988903, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
178c4fb
to
5e84007
Compare
const isSSPresent = storageSystems.find((ss) => ss.kind === model.kind); | ||
const isRhcs = externalStorage === OCSServiceModel.kind; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const isSSPresent = storageSystems.find((ss) => ss.kind === model.kind); | |
const isRhcs = externalStorage === OCSServiceModel.kind; | |
const isSSPresent = storageSystems.find((ss) => ss?.kind === model?.kind); | |
const isRhcs = externalStorage === OCSServiceModel?.kind; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it should be ss.spec.kind. Thanks for pointing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
await createStorageCluster(state); | ||
} else if (type === BackingStorageType.EXTERNAL) { | ||
const { createPayload, model, displayName } = getExternalStorage(externalStorage) || {}; | ||
const isRhcs = externalStorage === OCSServiceModel.kind; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const isRhcs = externalStorage === OCSServiceModel.kind; | |
const isRhcs = externalStorage === OCSServiceModel?.kind; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required. Its a constant object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh... ack !!
0f629e8
to
e2d2721
Compare
)} | ||
{isMCG ? ( | ||
<ReviewItem title={t('ceph-storage-plugin~Security')}> | ||
<ListItem>{t('ceph-storage-plugin~Encryption: Enabled')}</ListItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If encryption is always Enabled
for MCG shouldn't the "Enable Encryption" checkbox in previous "Security" step should always be checked+disabled as well ?? (User can further decide whether to check KMS setting or not).
Wdyt @afreen23 ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should be. I guess I missed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a6d6eb4
to
c5d45c4
Compare
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1988903 - updates request execution - fixes the hidden token field in kms form
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@afreen23: An error was encountered querying GitHub for users with public email (ratamir@redhat.com) for bug 1988903 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
@afreen23: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test ceph-storage-plugin |
@afreen23: All pull requests linked via external trackers have merged: Bugzilla bug 1988903 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |