New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1999931: move event sources add option to serverless add group #9958
Bug 1999931: move event sources add option to serverless add group #9958
Conversation
@nemesis09: This pull request references Bugzilla bug 1999931, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nemesis09: This pull request references Bugzilla bug 1999931, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@nemesis09: This pull request references Bugzilla bug 1999931, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @invincibleJai |
"groupId": "developer-catalog", | ||
"href": "/catalog?catalogType=EventSource", | ||
"groupId": "eventing", | ||
"href": "/catalog/ns/:namespace?catalogType=EventSource&provider=[\"Red+Hat\"]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to set default provider as this was the ask for 4.9 with community sources coming in with different provider
3ac7b63
to
8aa2908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified it on 4.8 cluster.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, nemesis09, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nemesis09: All pull requests linked via external trackers have merged: Bugzilla bug 1999931 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a 4.8 cherry pick PR from #9785
Fixes:
https://issues.redhat.com/browse/ODC-5928
https://bugzilla.redhat.com/show_bug.cgi?id=1999931
Problem/Statement:
Serverless card has add options related only to Eventing, so the group title should be changed to Eventing since Serverless has a broader scope.
Event sources add option currently shows in Catalog add group but should be shown under Eventing (previously Serverless) add group.
Solution/Description:
rename Serverless add group to Eventing.
Move Event sources add option under Eventing (previously Serverless) add group.
update affected tests.
Screens:
Test coverage:
N/A
only updated test data. no tests modified/created.
Browser conformation: