diff --git a/plugins/main/loopback/loopback.go b/plugins/main/loopback/loopback.go index db5e9964..eb228bb5 100644 --- a/plugins/main/loopback/loopback.go +++ b/plugins/main/loopback/loopback.go @@ -49,27 +49,6 @@ func cmdAdd(args *skel.CmdArgs) error { } func cmdDel(args *skel.CmdArgs) error { - if args.Netns == "" { - return nil - } - args.IfName = "lo" // ignore config, this only works for loopback - err := ns.WithNetNSPath(args.Netns, func(ns.NetNS) error { - link, err := netlink.LinkByName(args.IfName) - if err != nil { - return err // not tested - } - - err = netlink.LinkSetDown(link) - if err != nil { - return err // not tested - } - - return nil - }) - if err != nil { - return err // not tested - } - return nil } diff --git a/plugins/main/loopback/loopback_test.go b/plugins/main/loopback/loopback_test.go index 13693833..ae5859df 100644 --- a/plugins/main/loopback/loopback_test.go +++ b/plugins/main/loopback/loopback_test.go @@ -82,6 +82,7 @@ var _ = Describe("Loopback", func() { It("sets the lo device to DOWN", func() { Skip("TODO: add network name") + Skip("We don't want to tear loopback down") command.Env = append(environ, fmt.Sprintf("CNI_COMMAND=%s", "DEL")) session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)