Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1801343: Rebase to upstream 1.6.6 #23

Merged

Conversation

bcrochet
Copy link
Member

1. Why is this pull request needed and what does it do?

This pull request rebases CoreDNS to 1.6.6, and adds carried patches. There are numerous IPv6 fixes that are needed.

2. Which issues (if any) are related?

3. Which documentation changes (if any) need to be made?

None.

4. Does this introduce a backward incompatible change or deprecation?

Unaware of any.

dependabot-preview bot and others added 30 commits August 12, 2019 18:26
….1 (coredns#3114)

Bumps [gopkg.in/DataDog/dd-trace-go.v1](https://github.com/DataDog/dd-trace-go) from 1.16.0 to 1.16.1.
- [Release notes](https://github.com/DataDog/dd-trace-go/releases)
- [Commits](DataDog/dd-trace-go@v1.16.0...v1.16.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…redns#3116)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.21.2 to 1.22.3.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.21.2...v1.22.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Just building in master updates the deps.

Pushing this as a PR to get a clean build back.

Signed-off-by: Miek Gieben <miek@miek.nl>
In the setup function use plugin.Error() to wrap the errors with the
plugin name. Because there isn't a separate setup() function this is
done for all returned errors.

Remove *upstream.Upstream from the New parameters as this is always set
and adjust the tests to account for this.

Signed-off-by: Miek Gieben <miek@miek.nl>
Add notes for next release; azure was merged, nice to get that out, some
other bugfixes.

Signed-off-by: Miek Gieben <miek@miek.nl>
format and simplify; highlighted some stuff in route53_test.go that
could be further simplified.

Signed-off-by: Miek Gieben <miek@miek.nl>
Say a thing about 1.12.8 and HTTP/2

Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Just minor textual cleanup.
Signed-off-by: Palash Nigam <npalash25@gmail.com>

Closes: coredns#2822
Looks like there were some leftover in PR 3011 during
the merge conflict rebase. This PR removes the unneeded file
and fixed the plugin.cfg

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…s#3138)

This PR adds some content in clouddns plugin to mention about
the fact that privately hosted zone does not need to attach to
a VPC.
Also change PROJECT_NAME to PROJECTT_ID, and reformt the markdown
to replace tab with 4 whitespace.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* plugin/clouddns: tiny fixes for the README

Did a post-merge review. Fix a few typos.

Signed-off-by: Miek Gieben <miek@miek.nl>

* Naming;

coredns -> CoreDNS
clouddns -> Cloud DNS
and italics then the plugin's name are mentioned.

Signed-off-by: Miek Gieben <miek@miek.nl>
This feature introduce continuous fuzzing with the following
features:

* Ruzzing: fuzz-targets are run continuously on master
( the fuzzers are updated every time new code is pushed to master)
* Regresion: In addition to unit-tests travis runs all fuzz
targets through the generated corpus to catch bugs early  on
in the CI process before merge.
* Remove federation

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Rebuild and point to github.com/coredns/federation

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Export `localNodeName` => `LocalNodeName`, to be used by federation (until deprecation)

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Remove plugin/kubernetes/federation.go (=> kubernetes/federation repo)

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update github.com/coredns/federation

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* sticker-ci fix

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Since we use golang 1.12 and gomod, it is not necessary
to match the impor path to `/go/src/github.com/coredns/coredns`
in order to build coredns. For that reason the build command
inside docker could be simplified with:
```
$ docker run --rm -i -t -v $PWD:/v -w /v golang:1.12 make
```

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* fuzz: some cleanups

Signed-off-by: Miek Gieben <miek@miek.nl>

* smaller

Signed-off-by: Miek Gieben <miek@miek.nl>

* documentation

Signed-off-by: Miek Gieben <miek@miek.nl>

* comments

Signed-off-by: Miek Gieben <miek@miek.nl>
…oredns#3148)

Bumps [github.com/caddyserver/caddy](https://github.com/caddyserver/caddy) from 1.0.1 to 1.0.3.
- [Release notes](https://github.com/caddyserver/caddy/releases)
- [Commits](caddyserver/caddy@v1.0.1...v1.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/Azure/go-autorest/releases)
- [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md)
- [Commits](Azure/go-autorest@autorest/v0.8.0...autorest/v0.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@openshift-ci-robot
Copy link

@bcrochet: This pull request references Bugzilla bug 1801343, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1801339 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1801343: Rebase to upstream 1.6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2020
@ironcladlou
Copy link

/bugzilla refresh
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@openshift-ci-robot
Copy link

@ironcladlou: This pull request references Bugzilla bug 1801343, which is invalid:

  • expected dependent Bugzilla bug 1801339 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bcrochet
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@bcrochet: This pull request references Bugzilla bug 1801343, which is invalid:

  • expected dependent Bugzilla bug 1801339 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link

/approve

@bcrochet
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2020
@openshift-ci-robot
Copy link

@bcrochet: This pull request references Bugzilla bug 1801343, which is valid. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link

/approve

1 similar comment
@knobunc
Copy link

knobunc commented Feb 12, 2020

/approve

@mfojtik
Copy link
Member

mfojtik commented Feb 13, 2020

/approve

just because I know @ironcladlou is a smart guy.

@mfojtik mfojtik added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@mfojtik
Copy link
Member

mfojtik commented Feb 13, 2020

adding label manually, @stevekuznetsov acked it.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 13, 2020
@mfojtik
Copy link
Member

mfojtik commented Feb 13, 2020

/hold

we need to determine scariness level of this

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@mfojtik mfojtik removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 13, 2020
@mfojtik
Copy link
Member

mfojtik commented Feb 13, 2020

/hold cancel

note to next patch manager: please merge this, it soaked in 4.4 for 25d and is ready to go.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 19, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 052209a into openshift:release-4.3 Feb 19, 2020
@openshift-ci-robot
Copy link

@bcrochet: All pull requests linked via external trackers have merged. Bugzilla bug 1801343 has been moved to the MODIFIED state.

In response to this:

Bug 1801343: Rebase to upstream 1.6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet