Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1867735: Fix sync of openshift-config/cloud-provider-config ConfigMap #49

Merged
merged 3 commits into from Aug 11, 2020
Merged

Bug 1867735: Fix sync of openshift-config/cloud-provider-config ConfigMap #49

merged 3 commits into from Aug 11, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 10, 2020 •
edited

Fixed sync of openshift-config/cloud-provider-config into the driver namespace and add the operator enough permissions to actually do that.

Sync RBAC from CSO here, because it has been tested more in CSO.

@jsafrane
Fix sync of cloud-provider CA certificate
ccf7bb6 
Watch openshift-config namespace and check SyncConfigMap error to prevent
future regressions.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@jsafrane
Copy link
Contributor Author

Related to bz https://bugzilla.redhat.com/show_bug.cgi?id=1867735 (this needs to be picked into CSO where the role is actually instantiated).

Fedosin
Fedosin reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to update the cluster role and allow the operator to manage configmaps in the driver namespace

@jsafrane
Sync RBAC from CSO
e827d27 
Role in CSO has been tested thoroughly.
@jsafrane
Add RBAC to watch any configmap
8f60468 
To be able to sync openshift-config/cloud-provider-config to the operand
namespace.
@jsafrane jsafrane changed the title Fixed role namespace Fix ConfigMap sync Aug 11, 2020
@jsafrane jsafrane changed the title Fix ConfigMap sync Fix sync of openshift-config/cloud-provider-config ConfigMap Aug 11, 2020
@jsafrane
Copy link
Contributor Author

I suggest to update the cluster role and allow the operator to manage configmaps in the driver namespace

It was more complicated, but done

@jsafrane jsafrane changed the title Fix sync of openshift-config/cloud-provider-config ConfigMap Bug 1867735: Fix sync of openshift-config/cloud-provider-config ConfigMap Aug 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1867735, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867735: Fix sync of openshift-config/cloud-provider-config ConfigMap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane mentioned this pull request Aug 11, 2020
Merged
@Fedosin
Copy link
Contributor

Fedosin commented Aug 11, 2020

@jsafrane thanks a lot!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit a0315d8 into openshift:master Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Some pull requests linked via external trackers have merged: openshift/csi-driver-manila-operator#49. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1867735: Fix sync of openshift-config/cloud-provider-config ConfigMap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin left review comments

@gnufied gnufied Awaiting requested review from gnufied

@mandre mandre Awaiting requested review from mandre

Assignees

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @openshift-ci-robot @Fedosin @openshift-merge-robot