BUILD-256: update local dev and install doc for new operator approach #66
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
terraform / install flake e2e-aws-csi-driver /test e2e-aws-csi-driver |
|
ok all green e2e's @coreydaley |
README.md
Outdated
| to, and then employ the `deploy` make target from the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator), | ||
| where you set the `DRIVER_IMAGE` environment variable to that image reference as part of invoking `make deploy` from | ||
| your local clone of the the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator). | ||
| When running in this fashion, you also |
There was a problem hiding this comment.
| When running in this fashion, you also |
There was a problem hiding this comment.
Yeah this needs a bit more adjustment that this obvious straggling ref.
README.md
Outdated
| Check out the [current installation options](docs/install.md) to get the driver up and going. You'll need to have | ||
| sufficient privileges to create namespaces and ServiceAccounts, and then create `ClusterRoles`, `ClusterRoleBindings`, `DaemonSets` with the privileged bit set, | ||
| and the creation of `CSIDrivers`. | ||
| The maintenance of the related API objects and the deployment of this CSI driver are handled via the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator) |
There was a problem hiding this comment.
| The maintenance of the related API objects and the deployment of this CSI driver are handled via the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator) | |
| The maintenance of the related API objects and the deployment of this CSI driver are handled via the [Openshift CSI Driver for Shared Resources Operator](https://github.com/openshift/csi-driver-shared-resource-operator) |
README.md
Outdated
|
|
||
| If you are going to make code changes to this driver, and you'd like to test them against an OpenShift cluster, run the | ||
| `build-image` make target in this repository to capture those changes in an image reference whose remote registry and repository you can push | ||
| to, and then employ the `deploy` make target from the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator), |
There was a problem hiding this comment.
| to, and then employ the `deploy` make target from the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator), | |
| to, and then employ the `deploy` make target from the [Openshift CSI Driver for Shared Resources Operator](https://github.com/openshift/csi-driver-shared-resource-operator), |
README.md
Outdated
| `build-image` make target in this repository to capture those changes in an image reference whose remote registry and repository you can push | ||
| to, and then employ the `deploy` make target from the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator), | ||
| where you set the `DRIVER_IMAGE` environment variable to that image reference as part of invoking `make deploy` from | ||
| your local clone of the the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator). |
There was a problem hiding this comment.
| your local clone of the the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator). | |
| your local clone of the [Openshift CSI Driver for Shared Resoureces Operator](https://github.com/openshift/csi-driver-shared-resource-operator). |
gabemontero
force-pushed
the
update-install-local-dev
branch
from
e5104fe
to
9c68a2b
Compare
|
edits pushed @coreydaley thanks |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@gabemontero we should update openshift/release to not run the tests for markdown, owners, etc. |
good point ... if you have cycles, go for it not sure I'll get to it before my EOB today and PTO tomorrow |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws-csi-driver-disruptive |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/assign @coreydaley