Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and additional tests #43

Merged

Conversation

@jewzaam
Copy link
Member

commented Oct 7, 2019

No description provided.

}

// Return if alerts are disabled on the cluster
if _, ok := clusterDeployment.GetLabels()[config.ClusterDeploymentNoalertsLabel]; ok {

This comment has been minimized.

Copy link
@cblecker

cblecker Oct 8, 2019

Member

If this label is set to "false", what do you expect to happen?

This comment has been minimized.

Copy link
@jewzaam

jewzaam Oct 8, 2019

Author Member

It will still skip things, not checking the value of the label at all.

Also requeue if check clusterdeployment returns error
@jewzaam jewzaam force-pushed the jewzaam:more-refactoring-and-tests branch from 8f4d7ff to a45baea Oct 8, 2019
Copy link
Collaborator

left a comment

Minor comment

@jharrington22

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2019

/lgtm

@fahlmant

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fahlmant, jewzaam, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jewzaam,jharrington22]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 887c427 into openshift:master Oct 8, 2019
2 checks passed
2 checks passed
ci/prow/images Job succeeded.
Details
tide In merge pool.
Details
@jewzaam jewzaam deleted the jewzaam:more-refactoring-and-tests branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.