Updates deadmanssnitch-operator to Hive v1 API #52
+32,826
−4,428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-e-brumm
reviewed
Mar 18, 2020
This updates the Deadmanssnitch Operator to use the Hive v1 API. Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
clcollins
force-pushed
the
OSD-2755_hivev1
branch
from
0e9f80f
to
ef147fe
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c-e-brumm, clcollins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Deadmanssnitch Operator to use the Hive v1 API.
This includes updates to the
ClusterDeployment.Spec.Installedfield (replacesClusterDeployment.Status.Installed) andSecretMapping(replacesSecretReference).For the latter, some extra eyes on this diff would be appreciated.
REF: https://issues.redhat.com/browse/OSD-2755
Signed-off-by: Christopher Collins collins.christopher@gmail.com