Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SREP-2178 Permission parity with v3, add GET, WATCH Pod, ReplicationControllers, Services perm to dedicated-admins #87

Conversation

@rogbas
Copy link
Contributor

rogbas commented Nov 1, 2019

Adding GET, WATCH Pod, ReplicationController, Service permissions to dedicated-admins, as we have in OSD v3

Copy link
Collaborator

jharrington22 left a comment

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jharrington22, rogbas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jharrington22,rogbas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rogbas rogbas changed the title SREP-2178 Permission parity with v3, add GET, WATCH Pod perm to dedicated-admins SREP-2178 Permission parity with v3, add GET, WATCH Pod, ReplicationControllers, Services perm to dedicated-admins Nov 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 64859af into openshift:master Nov 1, 2019
3 checks passed
3 checks passed
ci.ext.devshift.net PR build
Details
ci/prow/images Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.