Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

This change adds the following help text to the namespace filter:
image

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@andreasgerstmayr: This pull request references OU-804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

This change adds the following help text to the namespace filter:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from IshwarKanse and zhuje May 15, 2025 10:11
"@perses-dev/dashboards": "0.51.0-rc.0",
"@perses-dev/plugin-system": "0.51.0-rc.0",
"@tanstack/react-query": "4.36.1",
"cheerio":"1.0.0-rc.12",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required to fix cheeriojs/cheerio#4024 when regenerating the locales with npm run i18n.

@andreasgerstmayr
Copy link
Contributor Author

/backport release-1.0

@andreasgerstmayr
Copy link
Contributor Author

/cherrypick release-1.0 release-0.4

@openshift-cherrypick-robot

@andreasgerstmayr: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.0 release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@IshwarKanse
Copy link
Member

/override ci/prow/upstream-amd64-aws-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e

In response to this:

/override ci/prow/upstream-amd64-aws-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreasgerstmayr,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreasgerstmayr
Copy link
Contributor Author

/label ux-approved
minimal changes
/label qe-approved
qe will be done post merge

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2025

@andreasgerstmayr: This pull request references OU-804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

This change adds the following help text to the namespace filter:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a2d1c26 into openshift:main May 16, 2025
5 checks passed
@openshift-cherrypick-robot

@andreasgerstmayr: #107 failed to apply on top of branch "release-1.0":

Applying: OU-804: Add help text to namespace filter
Using index info to reconstruct a base tree...
M	web/package.json
M	web/src/pages/TracesPage/Toolbar/AttributeFilters.tsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/pages/TracesPage/Toolbar/AttributeFilters.tsx
CONFLICT (content): Merge conflict in web/src/pages/TracesPage/Toolbar/AttributeFilters.tsx
Auto-merging web/package.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OU-804: Add help text to namespace filter

In response to this:

/cherrypick release-1.0 release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants