-
Notifications
You must be signed in to change notification settings - Fork 8
NO-JIRA: [Chore] Fix and improve Tracing UI plugin tests #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@IshwarKanse: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@IshwarKanse: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-lint |
|
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images, ci/prow/upstream-amd64-aws-lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tests pass using kube:admin provider but fail using IDP as expected due to bug https://issues.redhat.com/browse/OCPBUGS-59366 The CI uses the flexy-htpasswd-provider IDP. We need to wait for the issue to be resolved so that we have passing tests from CI. |
|
/cherry-pick release-1.0 |
|
@IshwarKanse: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etmurasaki, IshwarKanse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@IshwarKanse: new pull request created: #134 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The PR updates the tests with following changes.