-
Notifications
You must be signed in to change notification settings - Fork 8
TRACING-5505: [Chore] Improve Tracing UI plugin tests #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@IshwarKanse: This pull request references TRACING-5505 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@IshwarKanse: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-lint |
|
@IshwarKanse: This pull request references TRACING-5505 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images, ci/prow/upstream-amd64-aws-lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.0 |
|
@IshwarKanse: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@IshwarKanse: This pull request references TRACING-5505 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@IshwarKanse: This pull request references TRACING-5505 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse, JoaoFula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-lint |
|
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images, ci/prow/upstream-amd64-aws-lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-lint |
|
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images, ci/prow/upstream-amd64-aws-lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@IshwarKanse: new pull request created: #137 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Uh oh!
There was an error while loading. Please reload this page.