-
Notifications
You must be signed in to change notification settings - Fork 8
TRACING-5579: Support custom time range #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRACING-5579: Support custom time range #157
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
@andreasgerstmayr: This pull request references TRACING-5579 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@IshwarKanse could you update the e2e test? The HTML structure changed as I'm using the component from Perses now. |
|
@andreasgerstmayr Ack, will do. |
|
/test upstream-amd64-aws-e2e |
1 similar comment
|
/test upstream-amd64-aws-e2e |
|
@andreasgerstmayr Updated the tests, the job is passing now. |
|
@andreasgerstmayr Are we cherry-picking all the recent PRs to release-1.0 and 0.4 branch ? |
Yes, I'll do that in a single PR per branch, once all current PRs are merged. |
|
/label qe-approved |
|
@andreasgerstmayr: This pull request references TRACING-5579 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label ux-approved |
|
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |

Replace the custom
<DurationDropdown>with<TimeRangeControls>from Perses, which supports selecting a custom time range. Additionally, use<TimeRangeProviderWithQueryParams>instead of<TimeRangeProvider>to let Perses manage the query params handling.