Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

Replace the custom <DurationDropdown> with <TimeRangeControls> from Perses, which supports selecting a custom time range. Additionally, use <TimeRangeProviderWithQueryParams> instead of <TimeRangeProvider> to let Perses manage the query params handling.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@andreasgerstmayr: This pull request references TRACING-5579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Replace the custom <DurationDropdown> with <TimeRangeControls> from Perses, which supports selecting a custom time range. Additionally, use <TimeRangeProviderWithQueryParams> instead of <TimeRangeProvider> to let Perses manage the query params handling.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from IshwarKanse and zhuje October 9, 2025 18:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@andreasgerstmayr
Copy link
Contributor Author

AssertionError: Timed out retrying after 40000ms: Expected to find content: 'Last 30 minutes' within the element: <div.pf-v6-c-menu-toggle.pf-m-full-width.pf-m-typeahead> but never did.

@IshwarKanse could you update the e2e test? The HTML structure changed as I'm using the component from Perses now.

@IshwarKanse
Copy link
Member

@andreasgerstmayr Ack, will do.

@IshwarKanse
Copy link
Member

/test upstream-amd64-aws-e2e

1 similar comment
@IshwarKanse
Copy link
Member

/test upstream-amd64-aws-e2e

@IshwarKanse
Copy link
Member

@andreasgerstmayr Updated the tests, the job is passing now.

@IshwarKanse
Copy link
Member

@andreasgerstmayr Are we cherry-picking all the recent PRs to release-1.0 and 0.4 branch ?

@andreasgerstmayr
Copy link
Contributor Author

@andreasgerstmayr Are we cherry-picking all the recent PRs to release-1.0 and 0.4 branch ?

Yes, I'll do that in a single PR per branch, once all current PRs are merged.

@IshwarKanse
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2025

@andreasgerstmayr: This pull request references TRACING-5579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Replace the custom <DurationDropdown> with <TimeRangeControls> from Perses, which supports selecting a custom time range. Additionally, use <TimeRangeProviderWithQueryParams> instead of <TimeRangeProvider> to let Perses manage the query params handling.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhuje
Copy link
Contributor

zhuje commented Oct 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreasgerstmayr,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreasgerstmayr
Copy link
Contributor Author

/label ux-approved
same UX as in the monitoring view

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Oct 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 47ac476 into openshift:main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants