Skip to content

Conversation

@IshwarKanse
Copy link
Member

Updated the Cypress tests to work with the new Material-UI time range component based on #157

@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje October 10, 2025 06:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@IshwarKanse IshwarKanse changed the title Update tests for Material-UI time range component TRACING-5579: Update tests for Material-UI time range component Oct 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@IshwarKanse: This pull request references TRACING-5579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Updated the Cypress tests to work with the new Material-UI time range component based on #157

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@IshwarKanse
Copy link
Member Author

/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images

In response to this:

/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-fips-image-scan ci/prow/upstream-amd64-aws-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@IshwarKanse
Copy link
Member Author

/cherry-pick release-1.0

@openshift-cherrypick-robot

@IshwarKanse: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@IshwarKanse
Copy link
Member Author

/cherry-pick release-0.4

@openshift-cherrypick-robot

@IshwarKanse: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@IshwarKanse
Copy link
Member Author

/lgtm
/label qe-approved
/label ux-approved
/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@IshwarKanse: you cannot LGTM your own PR.

In response to this:

/lgtm
/label qe-approved
/label ux-approved
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR labels Oct 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@IshwarKanse: This pull request references TRACING-5579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Updated the Cypress tests to work with the new Material-UI time range component based on #157

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@vprashar2929 vprashar2929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IshwarKanse, vprashar2929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6fc589d into openshift:main Oct 10, 2025
5 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@IshwarKanse: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@IshwarKanse: new pull request created: #160

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@IshwarKanse: new pull request created: #161

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants