Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

@andreasgerstmayr andreasgerstmayr commented Oct 15, 2025

  • use absoluteTimeRange from TimeRangeProvider, which keeps the absolute time range during re-renders. Previously, I calculated the absolute time range from the relative time range (e.g. "last 30 minutes") on every re-render, which resulted in a network request on every re-render
  • refresh the absolute time range on every query change also in the filter bar
  • do not fetch search results twice when navigating back from the gantt chart to the search

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci-robot
Copy link

@andreasgerstmayr: This pull request explicitly references no jira issue.

In response to this:

  • use absoluteTimeRange from TimeRangeProvider, which keeps the absolute time range during re-renders. Previously, I calculated the absolute time range from the relative time range (e.g. "last 30 minutes") on every re-render, which resulted in a network request on every re-render
  • refresh the absolute time range on every query change also in the filter bar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@andreasgerstmayr
Copy link
Contributor Author

/label ux-approved
minimal UX changes

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Oct 15, 2025
@andreasgerstmayr andreasgerstmayr force-pushed the fix-filterbar-requests branch 2 times, most recently from 9e01e5b to f9908f8 Compare October 15, 2025 12:14
…nt flicker

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreasgerstmayr,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IshwarKanse
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a5ac532 into openshift:main Oct 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants