-
Notifications
You must be signed in to change notification settings - Fork 8
NO-JIRA: [chore] use selects from @patternfly/react-templates, show resource icon in dropdown, add jest #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: [chore] use selects from @patternfly/react-templates, show resource icon in dropdown, add jest #88
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
b2fcecf to
3f4775a
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @fkargbo |
|
/label ux-approved |
|
@andreasgerstmayr: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |

@patternfly/react-templatesNo notable UI/UX changes except for the resource icon (TempoStack / TempoMonolithic) in the dropdown:
