Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

@andreasgerstmayr andreasgerstmayr commented May 7, 2025

  • use selects from @patternfly/react-templates
  • show resource icon in dropdown
  • add jest

No notable UI/UX changes except for the resource icon (TempoStack / TempoMonolithic) in the dropdown:
image

@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje May 7, 2025 11:23
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr force-pushed the use-patternfly-react-templates branch from b2fcecf to 3f4775a Compare May 7, 2025 11:31
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@jgbernalp
Copy link
Contributor

cc @fkargbo

@fkargbo
Copy link

fkargbo commented May 8, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label May 8, 2025
@andreasgerstmayr andreasgerstmayr changed the title use selects from @patternfly/react-templates, show resource icon in dropdown, add jest NO-JIRA: [chore] use selects from @patternfly/react-templates, show resource icon in dropdown, add jest May 8, 2025
@openshift-ci-robot
Copy link

@andreasgerstmayr: This pull request explicitly references no jira issue.

In response to this:

  • use selects from @patternfly/react-templates
  • show resource icon in dropdown
  • add jest

No notable UI/UX changes except for the resource icon (TempoStack / TempoMonolithic) in the dropdown:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2025
@andreasgerstmayr
Copy link
Contributor Author

/label qe-approved
no relevant changes, let's do QE in the follow-up filterbar PR

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1bdee58 into openshift:main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants