Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

Description

This PR adds a PatternFly-native toolbar/filter bar to the traces page.

I plan on moving the TraceQL-specific code (the Filter folder) to Perses eventually, so we only keep the PatternFly-code in this repository.

Screenshots

Multiple selections

image

Filter by duration

image

TraceQL

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2025

@andreasgerstmayr: This pull request references OU-161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "OpenShift 4.14" instead.

In response to this:

Description

This PR adds a PatternFly-native toolbar/filter bar to the traces page.

I plan on moving the TraceQL-specific code (the Filter folder) to Perses eventually, so we only keep the PatternFly-code in this repository.

Screenshots

Multiple selections

image

Filter by duration

image

TraceQL

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and zhuje May 8, 2025 14:05
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@jgbernalp
Copy link
Contributor

/lgtm
nit: Does this mean that if the query is shown there are no selectable filters right?

@jgbernalp
Copy link
Contributor

cc @fkargbo

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2025
@andreasgerstmayr
Copy link
Contributor Author

/lgtm nit: Does this mean that if the query is shown there are no selectable filters right?

Yes. It's either filter bar or query, never both. This should avoid confusion when having an (outdated) selection in the filter bar and a modified query on the same page, and is similar to Jira's UX with the basic/advanced search for issues.

@fkargbo
Copy link

fkargbo commented May 11, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label May 11, 2025
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki
Copy link

/label qe-approved
testing will be performed post-merge along with other bugs and features.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025

@andreasgerstmayr: This pull request references OU-161 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "OpenShift 4.14" instead.

In response to this:

Description

This PR adds a PatternFly-native toolbar/filter bar to the traces page.

I plan on moving the TraceQL-specific code (the Filter folder) to Perses eventually, so we only keep the PatternFly-code in this repository.

Screenshots

Multiple selections

image

Filter by duration

image

TraceQL

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented May 13, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bf18bbc into openshift:main May 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants