-
Notifications
You must be signed in to change notification settings - Fork 8
OU-161: Add filter bar #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OU-161: Add filter bar #89
Conversation
|
@andreasgerstmayr: This pull request references OU-161 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "OpenShift 4.14" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
/lgtm |
|
cc @fkargbo |
Yes. It's either filter bar or query, never both. This should avoid confusion when having an (outdated) selection in the filter bar and a modified query on the same page, and is similar to Jira's UX with the basic/advanced search for issues. |
|
/label ux-approved |
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
|
@andreasgerstmayr: This pull request references OU-161 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "OpenShift 4.14" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
This PR adds a PatternFly-native toolbar/filter bar to the traces page.
I plan on moving the TraceQL-specific code (the
Filterfolder) to Perses eventually, so we only keep the PatternFly-code in this repository.Screenshots
Multiple selections
Filter by duration
TraceQL