Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

  • move @tanstack/query QueryClient higher up the chain to <TracingApp>, to make it usable on every page & to keep the cache
  • move useParams() hook in <TraceDetailPage> to a child element; this hook caused re-rendering of the entire <TraceDetailPage> due to https://issues.redhat.com/browse/OCPBUGS-56094

The re-rendering of <TraceDetailPage> every 10-20 seconds caused the cache to be emptied, triggering a re-load of the trace and hence a visible flicker of the Gantt Chart. By restructuring the hooks/elements as above, the trace is not fetched again and there is no flicker.

Resolves: https://issues.redhat.com/browse/OU-762

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025

@andreasgerstmayr: This pull request references OU-762 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

  • move @tanstack/query QueryClient higher up the chain to <TracingApp>, to make it usable on every page & to keep the cache
  • move useParams() hook in <TraceDetailPage> to a child element; this hook caused re-rendering of the entire <TraceDetailPage> due to https://issues.redhat.com/browse/OCPBUGS-56094

The re-rendering of <TraceDetailPage> every 10-20 seconds caused the cache to be emptied, triggering a re-load of the trace and hence a visible flicker of the Gantt Chart. By restructuring the hooks/elements as above, the trace is not fetched again and there is no flicker.

Resolves: https://issues.redhat.com/browse/OU-762

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented May 13, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm
/label ux-approved
no ux changes
/label qe-approved
QE can check post merge with COO

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025

@andreasgerstmayr: This pull request references OU-762 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

  • move @tanstack/query QueryClient higher up the chain to <TracingApp>, to make it usable on every page & to keep the cache
  • move useParams() hook in <TraceDetailPage> to a child element; this hook caused re-rendering of the entire <TraceDetailPage> due to https://issues.redhat.com/browse/OCPBUGS-56094

The re-rendering of <TraceDetailPage> every 10-20 seconds caused the cache to be emptied, triggering a re-load of the trace and hence a visible flicker of the Gantt Chart. By restructuring the hooks/elements as above, the trace is not fetched again and there is no flicker.

Resolves: https://issues.redhat.com/browse/OU-762

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 751060f into openshift:main May 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants