-
Notifications
You must be signed in to change notification settings - Fork 8
OU-762: fix flicker on trace detail page #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OU-762: fix flicker on trace detail page #94
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
@andreasgerstmayr: This pull request references OU-762 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@andreasgerstmayr: This pull request references OU-762 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tanstack/queryQueryClienthigher up the chain to<TracingApp>, to make it usable on every page & to keep the cacheuseParams()hook in<TraceDetailPage>to a child element; this hook caused re-rendering of the entire<TraceDetailPage>due to https://issues.redhat.com/browse/OCPBUGS-56094The re-rendering of
<TraceDetailPage>every 10-20 seconds caused the cache to be emptied, triggering a re-load of the trace and hence a visible flicker of the Gantt Chart. By restructuring the hooks/elements as above, the trace is not fetched again and there is no flicker.Resolves: https://issues.redhat.com/browse/OU-762