Skip to content

Upgrade TypeScript to latest 5.x and Jest to latest 29.x#317

Open
vojtechszocs wants to merge 2 commits into
openshift:mainfrom
vojtechszocs:bump-typescript
Open

Upgrade TypeScript to latest 5.x and Jest to latest 29.x#317
vojtechszocs wants to merge 2 commits into
openshift:mainfrom
vojtechszocs:bump-typescript

Conversation

@vojtechszocs
Copy link
Copy Markdown
Contributor

  • bump TypeScript to 5.9.3
  • bump Jest to 29.7.0
  • bump Jest related packages
    • ts-jest to 29.4.10
    • jest-axe to 10.0.0
  • bump @types/jest to latest 29.x
    • 📝 we still need @types/jest for global test types like describe, it, expect, jest.fn etc.
  • add jest-environment-jsdom
    • 📝 starting with Jest 28 this needs to be an explicit dependency
  • update jest.mocked calls in tests
    • 📝 using jest.mocked(fn) since in Jest 29 shallow mocking is the default setting
  • bump API Extractor & API Documenter to latest 7.x
    • 📝 fix top-level api-extractor script to refer to root node_modules/typescript/lib
  • bump ts-node to latest 10.x

@openshift-ci openshift-ci Bot requested review from florkbr and karelhala May 20, 2026 19:17
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
Comment thread package.json
"sample-app-install-cypress": "yarn workspace @monorepo/sample-app run cypress install",
"sample-app-test-component": "yarn workspace @monorepo/sample-app run cypress run --component",
"sample-app-test-e2e": "yarn workspace @monorepo/sample-app run cypress run --e2e",
"api-extractor": "api-extractor run --typescript-compiler-folder ./node_modules/typescript/lib",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - when running e.g. (cd packages/lib-core ; yarn api-extractor) this has resulted in

--typescript-compiler-folder packages/lib-core/node_modules/typescript/lib

which does not exist, so we're using $PROJECT_CWD which always points to workspace root directory.

Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2cf9de4 and 2 for PR HEAD 63aa790 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@vojtechszocs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/all-packages 63aa790 link true /test all-packages

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants