Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1840909: Updating cert restarts to also adhere to primaries instead of none #365

Merged

Conversation

ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented May 27, 2020

…dded missing status condition for primaries allocation
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@ewolinetz
Copy link
Contributor Author

This needs a bz to track against for 4.5, noticed it when trying to recreate https://bugzilla.redhat.com/show_bug.cgi?id=1835046

@ewolinetz ewolinetz changed the title Updating cert restarts to also adhere to primaries instead of none Bug 1840909: Updating cert restarts to also adhere to primaries instead of none May 27, 2020
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1840909, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840909: Updating cert restarts to also adhere to primaries instead of none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 27, 2020
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1840909, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840909: Updating cert restarts to also adhere to primaries instead of none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@periklis
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@jcantrill
Copy link
Collaborator

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 642b45a into openshift:master May 29, 2020
@openshift-ci-robot
Copy link

@ewolinetz: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#365. Bugzilla bug 1840909 has been moved to the MODIFIED state.

In response to this:

Bug 1840909: Updating cert restarts to also adhere to primaries instead of none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants