Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1883772: discover-etcd-initial-cluster: improve error handling when we dont scale member #56

Merged

Conversation

hexfusion
Copy link

discover-etcd-initial-cluster will fail without an error if the member has not been added to the cluster before etcd starts.

  47c2911fa3f192a1, started, etcd-bootstrap, https://192.168.1.239:2380, https://192.168.1.239:2379, false
  6eac2c0354f41bcb, started, wj45uos929a-4qdsw-master-2, https://192.168.1.29:2380, https://192.168.1.29:2379, false
  8b25c3c3bdeb7654, started, wj45uos929a-4qdsw-master-1, https://192.168.1.11:2380, https://192.168.1.11:2379, false
  #### attempt 0
        member={name="etcd-bootstrap", peerURLs=[https://192.168.1.239:2380}, clientURLs=[https://192.168.1.239:2379]
        member={name="wj45uos929a-4qdsw-master-2", peerURLs=[https://192.168.1.29:2380}, clientURLs=[https://192.168.1.29:2379]
        member={name="wj45uos929a-4qdsw-master-1", peerURLs=[https://192.168.1.11:2380}, clientURLs=[https://192.168.1.11:2379]
        target=nil, err=<nil>
  #### sleeping...
  #### attempt 1
        member={name="etcd-bootstrap", peerURLs=[https://192.168.1.239:2380}, clientURLs=[https://192.168.1.239:2379]
        member={name="wj45uos929a-4qdsw-master-2", peerURLs=[https://192.168.1.29:2380}, clientURLs=[https://192.168.1.29:2379]
        member={name="wj45uos929a-4qdsw-master-1", peerURLs=[https://192.168.1.11:2380}, clientURLs=[https://192.168.1.11:2379]
        target=nil, err=<nil>
  #### sleeping...
  #### attempt 2
        member={name="etcd-bootstrap", peerURLs=[https://192.168.1.239:2380}, clientURLs=[https://192.168.1.239:2379]
        member={name="wj45uos929a-4qdsw-master-2", peerURLs=[https://192.168.1.29:2380}, clientURLs=[https://192.168.1.29:2379]
        member={name="wj45uos929a-4qdsw-master-1", peerURLs=[https://192.168.1.11:2380}, clientURLs=[https://192.168.1.11:2379]
        target=nil, err=<nil>

…ale member

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1883772, which is invalid:

  • expected Bugzilla bug 1883772 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883772: discover-etcd-initial-cluster: improve error handling when we dont scale member

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@hexfusion
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1883772, which is invalid:

  • expected Bugzilla bug 1883772 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020
@retroflexer
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Author

cc @sdodson @markmc does this really need cherry-pick approved?

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 30, 2020
@sdodson
Copy link
Member

sdodson commented Sep 30, 2020

No, it shouldn't but the gap between now and when it'll be required is closing quickly. I'll just add the label rather than chasing the config change in the bot.

@openshift-merge-robot openshift-merge-robot merged commit faab032 into openshift:openshift-4.6 Sep 30, 2020
@openshift-ci-robot
Copy link

@hexfusion: Bugzilla bug 1883772 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1883772: discover-etcd-initial-cluster: improve error handling when we dont scale member

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the fix-no-member-add branch September 30, 2020 19:31
@hexfusion
Copy link
Author

/cherry-pick openshift-4,5

@openshift-cherrypick-robot

@hexfusion: cannot checkout openshift-4,5: error checking out openshift-4,5: exit status 1. output: error: pathspec 'openshift-4,5' did not match any file(s) known to git

In response to this:

/cherry-pick openshift-4,5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

/cherry-pick openshift-4.5

@openshift-cherrypick-robot

@hexfusion: new pull request created: #58

In response to this:

/cherry-pick openshift-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants