Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused bindata from the operator #54

Merged
merged 2 commits into from Oct 4, 2022

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Oct 3, 2022

PR bumping go to 1.19 revealed we still use bindata.go (with a wrong gofmt). Removing it, we use embed package to get our yaml assets.

Bump go to 1.19 to check gofmt.

@openshift/storage

And reformat sources.
We use "embed" package.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 3, 2022

/label docs-approved
/label px-approved

This is not user-facing change

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 4, 2022

/label qe-approved
This PR removes an unused file an CI is green.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3667a1b into openshift:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants