Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create environment #149

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Jul 18, 2022

Fixes

https://issues.redhat.com/browse/HAC-1608

Description

Add Form view to create Environments

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image

image

image

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #149 (52cec92) into main (73e3674) will increase coverage by 2.37%.
The diff coverage is 78.02%.

❗ Current head 52cec92 differs from pull request most recent head 190f1ed. Consider uploading reports for the commit 190f1ed to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   59.25%   61.62%   +2.37%     
==========================================
  Files         236      249      +13     
  Lines        4535     4862     +327     
  Branches     1079     1150      +71     
==========================================
+ Hits         2687     2996     +309     
- Misses       1755     1773      +18     
  Partials       93       93              
Impacted Files Coverage Δ
src/hooks/useEnvironments.ts 0.00% <0.00%> (ø)
src/pages/CreateEnvironmentPage.tsx 0.00% <0.00%> (ø)
src/shared/components/dropdown/BasicDropdown.tsx 100.00% <ø> (ø)
src/shared/components/formik-fields/field-types.ts 100.00% <ø> (ø)
...ents/Environment/create/ParentEnvironmentField.tsx 83.33% <83.33%> (ø)
...omponents/Environment/create/CreateEnvironment.tsx 85.18% <85.18%> (ø)
src/components/Environment/EnvironmentListView.tsx 100.00% <100.00%> (ø)
...nents/Environment/create/CreateEnvironmentForm.tsx 100.00% <100.00%> (ø)
src/components/Environment/environment-utils.ts 100.00% <100.00%> (ø)
.../shared/components/formik-fields/DropdownField.tsx 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2c7ff...190f1ed. Read the comment docs.

@sahil143
Copy link
Contributor Author

/retest

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation shows error even when the dropdown item is selected.
Screenshot 2022-07-19 at 4 16 38 PM

add create environment form

add form schema for environment form, update styles for form

add unit tests for create Environment Form
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@sahil143: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit bbf2992 into openshift:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants