-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create environment #149
Create environment #149
Conversation
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 59.25% 61.62% +2.37%
==========================================
Files 236 249 +13
Lines 4535 4862 +327
Branches 1079 1150 +71
==========================================
+ Hits 2687 2996 +309
- Misses 1755 1773 +18
Partials 93 93
Continue to review full report at Codecov.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0cd06ec
to
52cec92
Compare
add create environment form add form schema for environment form, update styles for form add unit tests for create Environment Form
52cec92
to
190f1ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sahil143: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes
https://issues.redhat.com/browse/HAC-1608
Description
Add Form view to create Environments
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: