Add support for hostedCluster to delete all nodePools#13
Merged
Conversation
enxebre
force-pushed
the
delete-nodepools
branch
from
96296af to
3bbdc14
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
csrwng
reviewed
Feb 3, 2021
| nodePoolList, | ||
| client.MatchingFields{key: value}, | ||
| ); err != nil { | ||
| return nil, fmt.Errorf("failed getting machine list: %v", err) |
| return ctrl.Result{}, nil | ||
| } | ||
|
|
||
| func (r *HostedClusterReconciler) listNodePool(key, value string) ([]hyperv1.NodePool, error) { |
Contributor
There was a problem hiding this comment.
s/listNodePool/listNodePools/
| }, | ||
| nodePools, err := r.listNodePool(clusterNameIndexFieldName, req.Name) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get nodePools by cluster name: %w", err) |
Contributor
There was a problem hiding this comment.
might be good to include the cluster name in the error message
| } | ||
| r.Infra = &infra | ||
|
|
||
| // index nodePool by clusterName |
Currently when deleting a hostedCluster it won't delete any owned nodePool causing a race between CAPI deleting the underlying machineSets and the nodePool CR wanting to recreate them.
enxebre
force-pushed
the
delete-nodepools
branch
from
3bbdc14 to
6eb4f29
Compare
Contributor
|
lgtm |
Contributor
|
/lgtm |
zanetworker
pushed a commit
to zanetworker/hypershift
that referenced
this pull request
Sep 28, 2021
Add konnectivity server and agent
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when deleting a hostedCluster it won't delete any owned nodePool causing a race between CAPI deleting the underlying machineSets and the nodePool CR wanting to recreate them.