Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpo): adhere to upgrade order from kube version skew policy #1322

Merged
merged 1 commit into from May 24, 2022

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Apr 27, 2022

What this PR does / why we need it:
This CPO change ensures kube-apiserver and openshift-apiserver deployments to roll out all updated replicas before proceeding with reconciliation. This makes it so that hypershift control planes adheres to the supported upgrade order as described in kube version skew policy.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #1222

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning April 27, 2022 22:00
@hasueki
Copy link
Contributor Author

hasueki commented Apr 28, 2022

/retest

support/util/deployment.go Outdated Show resolved Hide resolved
crclient "sigs.k8s.io/controller-runtime/pkg/client"
)

func IsDeploymentReady(ctx context.Context, c crclient.Client, deployment *appsv1.Deployment) (bool, error) {
Copy link
Member

@enxebre enxebre May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orthogonal to this PR I think we should review this pattern where we let the cpo use a top level shared library. This might mean a CPO backport fix will enforce an unnecessary backport to the hypershift operator as well. cc @alvaroaleman @csrwng @sjenning @ironcladlou

@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 6b71ba7
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6272ddc8329adb000928a257
😎 Deploy Preview https://deploy-preview-1322--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hasueki
Copy link
Contributor Author

hasueki commented May 5, 2022

/retest

@hasueki
Copy link
Contributor Author

hasueki commented May 10, 2022

@sjenning @enxebre @csrwng Please re-review and I'm happy to make further adjustments, if needed.

@relyt0925
Copy link
Contributor

/retest

1 similar comment
@csrwng
Copy link
Contributor

csrwng commented May 24, 2022

/retest

@csrwng
Copy link
Contributor

csrwng commented May 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hasueki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@csrwng
Copy link
Contributor

csrwng commented May 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@hasueki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-nested 6b71ba7 link false /test e2e-aws-nested

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ee40037 into openshift:main May 24, 2022
@hasueki
Copy link
Contributor Author

hasueki commented May 25, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot

@hasueki: new pull request created: #1409

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki
Copy link
Contributor Author

hasueki commented May 25, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot

@hasueki: new pull request created: #1410

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki hasueki deleted the upgrade-order branch July 22, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure control plane roll out adheres to Kubernetes version skew policy
9 participants