Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage ignition server from CPO #1446

Merged
merged 1 commit into from Jun 7, 2022

Conversation

alvaroaleman
Copy link
Contributor

This changes moves the ignition server management from the HO into the
CPO. In order to stay backwards compatible, the HO will still reconcile
the ignition server if the CPO isn't opted into doing that through a
Docker image label.

Ref https://issues.redhat.com/browse/HOSTEDCP-411

/cc @enxebre

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

This changes moves the ignition server management from the HO into the
CPO. In order to stay backwards compatible, the HO will still reconcile
the ignition server if the CPO isn't opted into doing that through a
Docker image label.

Ref https://issues.redhat.com/browse/HOSTEDCP-411
@openshift-ci openshift-ci bot requested a review from enxebre June 7, 2022 19:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@sjenning
Copy link
Contributor

sjenning commented Jun 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

@alvaroaleman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-nested 8fa88bd link false /test e2e-aws-nested

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0efe494 into openshift:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants