New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily override the CAPI AWS provider image #1933
Temporarily override the CAPI AWS provider image #1933
Conversation
…uster-api and other services
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hypershift-operator/main.go
Outdated
ComponentImages: map[string]string{ | ||
// TODO: Remove this override when we update CAPA to match the master branch of openshift/cluster-api-provider-aws | ||
// Currently, this image points to CAPA in OCP release 4.12.0-ec.5 | ||
"aws-cluster-api-controllers": "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:0fe3b95dad471e6840e8f38624fcd0ee6cbc92503460fe7f3503e640e13402d3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use a multi-arch image here rather than an x86 only image?
Ex: quay.io/openshift-release-dev/ocp-release:4.12.0-rc.3-multi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bryan-cox yup, that makes sense, will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
This allows OCP 4.13 clusters to work while we bump the CAPA dependency (and API version) in our code
c5e7b02
to
9eb0b94
Compare
/lgtm |
@csrwng: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This allows OCP 4.13 clusters to work while we bump the CAPA dependency (and API version) in our code
Checklist