New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-969: Move metrics #2495
HOSTEDCP-969: Move metrics #2495
Conversation
Atm we have high frequency reconciliation loop where we constantly review the over all state of the world by looping over all clusters. It's worth noting that With this particular change we'll be capturing something different i.e. "when we remove all finalisers we own", which doesn't necessarily is the same than "when the HC is removed from etcd".
This is to avoid noise in metrics that would be cause by condition flipping from true->false->true
This is a first step towards having the abiility to identify and visualise more granular SLIs that might be bottle necks impacting our SLOs. It provides a picture on duration for CP components to available
@enxebre: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@enxebre: This pull request references HOSTEDCP-969 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@enxebre: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@enxebre: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
b756361
into
openshift:release-4.13
What this PR does / why we need it:
Cherry-picks
#2347
#2348
#2440
#2459
#2463
#2477
#2479
#2483
#2489
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist