Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agent platform to docs #979

Merged
merged 1 commit into from Feb 9, 2022
Merged

Add agent platform to docs #979

merged 1 commit into from Feb 9, 2022

Conversation

avishayt
Copy link
Contributor

@avishayt avishayt commented Feb 6, 2022 •
edited by openshift-ci bot

What this PR does / why we need it:
Add documentation for using the agent platform

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #MGMT-8469

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@netlify
Copy link

netlify bot commented Feb 6, 2022 •
edited

✔️ Deploy Preview for hypershift-docs ready!

🔨 Explore the source changes: be1ca86

🔍 Inspect the deploy log: https://app.netlify.com/sites/hypershift-docs/deploys/62038650bf46850007670e80

😎 Browse the preview: https://deploy-preview-979--hypershift-docs.netlify.app

@enxebre
Copy link
Member

enxebre commented Feb 7, 2022

Please update the mkdocs.yml file to ensure the new file is rendered.
I think this should instead belong to getting-started/Agent-platform?

@avishayt
Copy link
Contributor Author

avishayt commented Feb 7, 2022

I think this should instead belong to getting-started/Agent-platform?

Do you mean that it should be a section in getting-started.md?

eranco74
eranco74 reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@avishayt
Copy link
Contributor Author

avishayt commented Feb 8, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@enxebre
Copy link
Member

enxebre commented Feb 8, 2022 •
edited

Do you mean that it should be a section in getting-started.md?

Yes, I think I'd rather have getting-started-aws, getting-started-agent and then getting-started-kubevirt #985

wdyt?

cc @csrwng @alvaroaleman @ironcladlou @sjenning

@enxebre enxebre mentioned this pull request Feb 8, 2022
Merged
4 tasks
@sjenning
Copy link
Contributor

sjenning commented Feb 8, 2022

I do see HostedCluster and NodePool create/manage/destroy being sufficiently different between the platforms that they justify per-platform docs on this.

In fact, I was going to write one up for bare-metal.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@avishayt
Copy link
Contributor Author

avishayt commented Feb 9, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@enxebre
Copy link
Member

enxebre commented Feb 9, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@avishayt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eranco74
Copy link
Contributor

eranco74 commented Feb 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 96f0a65 into openshift:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

@enxebre enxebre Awaiting requested review from enxebre

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@eranco74 eranco74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@avishayt @enxebre @sjenning @eranco74 @openshift-merge-robot