Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reconcile images that are used by the assisted service #44

Merged
merged 1 commit into from Apr 22, 2022

Conversation

dtantsur
Copy link
Member

We don't know how to build images suitable for it. Better ignore the
images completely and let the assisted service handle them.

Related: openshift/enhancements#1059

@dtantsur
Copy link
Member Author

/cc @zaneb @dhellmann @flaper87

@dtantsur
Copy link
Member Author

/retest

etcd problems, the deployment finished successfully

@zaneb
Copy link
Member

zaneb commented Apr 13, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
We don't know how to build images suitable for it. Better ignore the
images completely and let the assisted service handle them.

Related: openshift/enhancements#1059
@dtantsur
Copy link
Member Author

/retest

@dtantsur
Copy link
Member Author

/test e2e-metal-ipi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2022

@dtantsur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@honza
Copy link
Member

honza commented Apr 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit 869c1f2 into openshift:main Apr 22, 2022
@dtantsur dtantsur deleted the infraenv branch April 22, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants