Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] Allow DELETE for incomplete uploads #151

Merged

Conversation

dmage
Copy link
Member

@dmage dmage commented Jan 24, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2019
@bparees
Copy link
Contributor

bparees commented Jan 24, 2019

We need to add CI coverage for the 3.9 branch

@dmage
Copy link
Member Author

dmage commented Jan 24, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@dmage
Copy link
Member Author

dmage commented Jan 25, 2019

openshift/release#2698

@bparees
Copy link
Contributor

bparees commented Jan 28, 2019

@dmage given the state of our CI and the relatively simple nature of this change, i'm comfortable merging it if you are.

@dmage
Copy link
Member Author

dmage commented Jan 28, 2019

Yes, at least we know that unit tests are green, so I'm ok.
/hold cancel

@dmage dmage removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@bparees
Copy link
Contributor

bparees commented Jan 28, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 09cb07d into openshift:release-3.9 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants