Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1766113: Checking if image name is valid, prune otherwise. #199

Merged
merged 1 commit into from Nov 11, 2019
Merged

Bug 1766113: Checking if image name is valid, prune otherwise. #199

merged 1 commit into from Nov 11, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #194

/assign ricardomaraschini

@ricardomaraschini
Checking if image name is valid, prune otherwise.
4398a5e 
In some cases we have some images on the blob storage that contain names
considered to be invalid by the ImageStream API. Names containing / or
even % are not considered valid for Images.

As some customers are not able to prune their images due to this error
this patch adds a check and sets the image to be pruned if it contains
an invalid name(they should not be there anyways).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 8, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1749256, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-3.11] Bug 1749256: Checking if image name is valid, prune otherwise.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2019
@ricardomaraschini
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2019
@openshift-bot
Copy link
Contributor

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1749256, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor

/retitle [release-3.11] Bug 1766113: Checking if image name is valid, prune otherwise.

@openshift-ci-robot openshift-ci-robot changed the title [release-3.11] Bug 1749256: Checking if image name is valid, prune otherwise. [release-3.11] Bug 1766113: Checking if image name is valid, prune otherwise. Oct 28, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 28, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1766113, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-3.11] Bug 1766113: Checking if image name is valid, prune otherwise.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2019
@ricardomaraschini
Copy link
Contributor

/test integration

@ricardomaraschini
Copy link
Contributor

/assign @dmage @adambkaplan

@ricardomaraschini
Copy link
Contributor

/test integration

1 similar comment
@ricardomaraschini
Copy link
Contributor

/test integration

@dmage
Copy link
Member

dmage commented Oct 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ricardomaraschini
Copy link
Contributor

/hold

Still need to check why tests are being OOMKilled.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@ricardomaraschini
Copy link
Contributor

Awaiting for openshift/release#5723

@ricardomaraschini
Copy link
Contributor

/test integration

1 similar comment
@ricardomaraschini
Copy link
Contributor

/test integration

@ricardomaraschini
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@ricardomaraschini
Copy link
Contributor

/retitle Bug 1766113: Checking if image name is valid, prune otherwise.

@openshift-ci-robot openshift-ci-robot changed the title [release-3.11] Bug 1766113: Checking if image name is valid, prune otherwise. Bug 1766113: Checking if image name is valid, prune otherwise. Nov 6, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dmage
Copy link
Member

dmage commented Nov 6, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ricardomaraschini
Copy link
Contributor

/test e2e-gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ricardomaraschini
Copy link
Contributor

/hold trying to check what is going on with the tests on GCP.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@ricardomaraschini
Copy link
Contributor

/test e2e-gcp

@adambkaplan
Copy link
Contributor

/test e2e-aws

GCP tests appear to have been skipped?

@ricardomaraschini
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 269e997 into openshift:release-3.11 Nov 11, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1766113 has been moved to the MODIFIED state.

In response to this:

Bug 1766113: Checking if image name is valid, prune otherwise.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar Awaiting requested review from miminar

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dmage dmage

@ricardomaraschini ricardomaraschini

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @ricardomaraschini @openshift-bot @dmage @adambkaplan @openshift-merge-robot