Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11v2] Bug 1814722: bump(*): fix err shadowing in gcs driver #230

Merged
merged 1 commit into from Apr 29, 2020
Merged

[3.11v2] Bug 1814722: bump(*): fix err shadowing in gcs driver #230

merged 1 commit into from Apr 29, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Mar 18, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@dmage
Copy link
Member Author

dmage commented Mar 18, 2020

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

/hold

Need to get e2e running again

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@smarterclayton
Copy link
Contributor

/test e2e-gcp

2 similar comments
@smarterclayton
Copy link
Contributor

/test e2e-gcp

@smarterclayton
Copy link
Contributor

/test e2e-gcp

@smarterclayton
Copy link
Contributor

Mirrored to quay.io/openshift/origin-test-fixes:docker-registry-gcs-eat-error-311

@dmage dmage mentioned this pull request Mar 23, 2020
Closed
@dmage dmage changed the title [3.11v2] bump(*): fix err shadowing in gcs driver [3.11v2] Bug 1814722: bump(*): fix err shadowing in gcs driver Mar 23, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1814722, which is invalid:

  • expected dependent Bugzilla bug 1814720 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[3.11v2] Bug 1814722: bump(*): fix err shadowing in gcs driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 23, 2020
@smarterclayton
Copy link
Contributor

/hold cancel

This is ready from my perspective, after this went in we have dropped to seeing almost zero 500 internal server errors (and none of those had the same symptoms as before). So there's a good chance this caught it, or another did, and we have 4 weeks of soak on this code, so I think this is as good a bump as we can do.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@dmage
Copy link
Member Author

dmage commented Apr 27, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1814722, which is invalid:

  • expected the bug to target the "3.11.z" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Apr 27, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1814722, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

5 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1814720 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 27, 2020
@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Member Author

dmage commented Apr 27, 2020

/hold

e2e-gcp is broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020
@dmage
Copy link
Member Author

dmage commented Apr 27, 2020

/test e2e-gcp

@coreydaley
Copy link
Member

/retest

@dmage
Copy link
Member Author

dmage commented Apr 29, 2020

We have a green test for this PR: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_image-registry/230/pull-ci-openshift-image-registry-release-3.11-e2e-gcp/42

/override ci/prow/e2e-gcp
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: Overrode contexts on behalf of dmage: ci/prow/e2e-gcp

In response to this:

We have a green test for this PR: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_image-registry/230/pull-ci-openshift-image-registry-release-3.11-e2e-gcp/42

/override ci/prow/e2e-gcp
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Apr 29, 2020

/hold

now we have problems with images

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@dmage
Copy link
Member Author

dmage commented Apr 29, 2020

/retest images

@openshift-ci-robot
Copy link
Contributor

@dmage: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-gcp
  • /test images
  • /test integration
  • /test unit

Use /test all to run all jobs.

In response to this:

/retest images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Apr 29, 2020

/test images

@dmage
Copy link
Member Author

dmage commented Apr 29, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7fcb70b into openshift:release-3.11 Apr 29, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: All pull requests linked via external trackers have merged: openshift/image-registry#230. Bugzilla bug 1814722 has been moved to the MODIFIED state.

In response to this:

[3.11v2] Bug 1814722: bump(*): fix err shadowing in gcs driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmage @smarterclayton @openshift-ci-robot @coreydaley @openshift-merge-robot