Bug 1923536: forward http.StatusTooManyRequests to client

[flavianmissi]

makes the registry forward http.StatusTooManyRequests back
to the client during pullthrough operations.

[openshift-ci]

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dmage]

I'm ok with keeping these debug logs, they are disabled by default anyway.
/approve

[openshift-ci]

@flavianmissi: This pull request references Bugzilla bug 1923536, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1923536: forward http.StatusTooManyRequests to client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@flavianmissi: This pull request references Bugzilla bug 1923536, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1923536: forward http.StatusTooManyRequests to client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

/bugzilla refresh

[openshift-ci]

@flavianmissi: This pull request references Bugzilla bug 1923536, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

/assign @ricardomaraschini

[xiuwang]

/label qe-approved
Add verify steps in bugzilla 1923536

[flavianmissi]

/assign @dmage

[dmage]

Ideally we should have new tests in every bug fix, but given this is a very long standing issue, let's merge it!
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/dockerregistry/OWNERS [dmage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dmage]

/cherrypick release-4.10

[openshift-cherrypick-robot]

@dmage: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@flavianmissi: All pull requests linked via external trackers have merged:

• openshift/image-registry#329

Bugzilla bug 1923536 has been moved to the MODIFIED state.

In response to this:

Bug 1923536: forward http.StatusTooManyRequests to client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavianmissi]

Ideally we should have new tests in every bug fix, but given this is a very long standing issue, let's merge it!

agreed! can still write the tests, but I'll need some help - spent a few hours when I was writing this but couldn't really grasp how I could cover it :/

[openshift-cherrypick-robot]

@dmage: new pull request created: #332

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.