New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.3] Bug 1835094: Collect certificates #104
[release-4.3] Bug 1835094: Collect certificates #104
Conversation
library-go should more correctly handle context termination.
We are currently returning all of them and it is confusing.
@martinkunc: This pull request references Bugzilla bug 1835094, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkunc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@martinkunc: This pull request references Bugzilla bug 1835094, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@martinkunc: This pull request references Bugzilla bug 1835094, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@martinkunc: All pull requests linked via external trackers have merged: . Bugzilla bug 1835094 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Picks changes for #70 with necessary go mod update.
The main purpose is to keep it up to date easy future merging of changes.