New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1923888: Fixes error metadata gathering #325
Bug 1923888: Fixes error metadata gathering #325
Conversation
/retest |
One minor suggestion. It would be nice to change https://github.com/openshift/insights-operator/pull/325/files#diff-95486e6db8a4eaef301b750a6b2feebdcb2aad64f8f3fc601f0d7ca58d6ec197R102 to |
I verified locally that the errors are correctly serialized in the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@0sewa0: This pull request references Bugzilla bug 1923888, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@0sewa0: This pull request references Bugzilla bug 1923888, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@0sewa0: All pull requests linked via external trackers have merged: Bugzilla bug 1923888 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Errors produced by the gather-functions are supposed to be stored in the metadata, but because it was left up to go on how to parse/store the errors, so they either showed up correctly or just an empty object, which is not really helpful.
This PR fixes that by just storing the error string (ie.:
error.Error()
).Categories
Sample archive
Documentation
Unit Tests
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
not necessary
References