Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1936782: Gather "cluster-monitoring-config" configmap #366

Merged

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Mar 8, 2021

This PR extends the original configmap gatherer to also gather the cluster-monitoring-config configmap from the openshift-monitoring namespace. The original gatherer doesn't include the corresponding namespace name in the configmap's path in the archive so it required to update the sample archive as well.

This data is required for the nomination (see link below) for a new external rule.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

See the renamed JSON files and the new:

  • docs/insights-archive-sample/config/configmaps/openshift-monitoring/cluster-monitoring-config/config.json

Documentation

Documentation updated in:

  • docs/gathered-data.md

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://issues.redhat.com/browse/INSIGHTOCP-275
https://bugzilla.redhat.com/show_bug.cgi?id=1936782
https://access.redhat.com/solutions/???

@openshift-ci-robot
Copy link
Contributor

@tremes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug : Gather "cluster-monitoring-config" configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2021
@tremes tremes changed the title Bug <TODO>: Gather "cluster-monitoring-config" configmap [release-4.6] Bug <TODO>: Gather "cluster-monitoring-config" configmap Mar 8, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] Bug : Gather "cluster-monitoring-config" configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes changed the title [release-4.6] Bug <TODO>: Gather "cluster-monitoring-config" configmap [release-4.6] Bug 1936782: Gather "cluster-monitoring-config" configmap Mar 9, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 9, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1936782, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1925408 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1925408 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

[release-4.6] Bug 1936782: Gather "cluster-monitoring-config" configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1936782, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1925408 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1925408 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

[release-4.6] Bug 1936782: Gather "cluster-monitoring-config" configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0
Copy link
Contributor

0sewa0 commented Mar 9, 2021

do I need to add/do in the cluster for the config/configmaps/openshift-monitoring/cluster-monitoring-config/config.json to appear ?

@tremes
Copy link
Contributor Author

tremes commented Mar 9, 2021

@0sewa0 yes or use some of Quicklab cluster. The configmap is there AFAIK

@0sewa0
Copy link
Contributor

0sewa0 commented Mar 9, 2021

/lgtm
tested with quicklab cluster
config/configmaps/openshift-monitoring/cluster-monitoring-config/config.json:

{"prometheusK8s":{"retention":"7d"}}

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford crawford changed the title [release-4.6] Bug 1936782: Gather "cluster-monitoring-config" configmap Bug 1936782: Gather "cluster-monitoring-config" configmap Mar 12, 2021
@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit d2b4bcf into openshift:release-4.6 Mar 12, 2021
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1936782 has been moved to the MODIFIED state.

In response to this:

Bug 1936782: Gather "cluster-monitoring-config" configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the configmap_update_4.6 branch May 6, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants