New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1942068: Gahter datahubs.installers.datahub.sap.com resources from SAP clusters #383
[release-4.7] Bug 1942068: Gahter datahubs.installers.datahub.sap.com resources from SAP clusters #383
Conversation
@natiiix: This pull request references Bugzilla bug 1942068, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e |
/bugzilla refresh |
@tremes: This pull request references Bugzilla bug 1942068, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
927fdbc
to
53bd421
Compare
} | ||
|
||
func gatherSAPDatahubs(ctx context.Context, dynamicClient dynamic.Interface) ([]record.Record, []error) { | ||
datahubsResource := schema.GroupVersionResource{Group: "installers.datahub.sap.com", Version: "v1alpha1", Resource: "datahubs"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a variable for this GVR in 4.7. Can you please update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was just now added with the changes that I rebased on top of because it wasn't there when I created the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your guess is correct AFAIK :)
namespace: example-namespace2 | ||
` | ||
|
||
datahubsResource := schema.GroupVersionResource{Group: "installers.datahub.sap.com", Version: "v1alpha1", Resource: "datahubs"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here pls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the same code as in master
. The idea here was that if someone introduces a type into the constant, then the tests would happily pass if they also use the constant. However, if each of them has their own hardcoded GVR variable, then they will start failing.
Pretty straightforward & clear. I ran it locally as usual, but no SAP on my cluster. Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@natiiix: All pull requests linked via external trackers have merged: Bugzilla bug 1942068 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is a backport of #376, which is another SAP enhancement. Much like the others, this one will also have to be backported to 4.6.z for us to see any useful results in a reasonable amount of time.
The presence of the Datahubs resource(s) is used for the identification of SAP (SDI) clusters. As such, it has been decided that it should be collected from all of them in order for the team processing the IO archives to be able to tell SAP clusters apart from the remaining clusters. It is possible that all of the data gathered exclusively from SAP clusters could be missing, in which case it would be impossible to determine if a cluster has an SDI installation or not. This enhancement fixes that issue by gathering a resource that should, universally, be present on all SAP clusters. By gathering this resource, we also safely know which namespace was SDI (attempted to be) installed into.
We came up with a hopefully reasonably clear and unambiguous directory structure for custom resources (see "Sample archive" section below).
Categories
Sample archive
docs/insights-archive-sample/customresources/installers.datahub.sap.com/datahubs/sdi/default.json
Documentation
docs/gathered-data.md
- "SAPDatahubs" sectionUnit Tests
pkg/gather/clusterconfig/sap_datahubs_test.go
-TestSAPDatahubs
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No.
References
Jira Task: https://issues.redhat.com/browse/CCXDEV-4317
Bugzilla Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1942068
Base PR: #376