New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api to metrics service changed from prometheus to legacyregistry #42
api to metrics service changed from prometheus to legacyregistry #42
Conversation
Hi @SamuelStuchly. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nice catch @SamuelStuchly. |
/ok-to-test |
I've tested this, but I'm still not sure why it got broken (seems like related to rebase to k8s 1.16). @mfojtik any idea? Michal also: can you confirm other operators using the same approach are still reporting the metrics ok (such as cluster-auth-operator https://github.com/openshift/cluster-authentication-operator/blob/master/pkg/version/version.go - I don't see the metric openshift_cluster_authentication_operator_build_info in nightly clusters). I've seen What is the recommended way doing this anyway? |
@iNecas yes Ivan, it was caused by rebasing k8s. Previously the History of this file: |
|
/lgtm, as I've seen this working. For the custom metrics, I would like to see some other openshift operator going over this process, to be able to inspire from it: the OpenShift core team will probably be more effective finding the right way of doing this that we do. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iNecas, SamuelStuchly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Api to metrics service has been changed suddenly without our knowledge, causing metrics to not be registered anymore, therefore this change is needed to resolve the issue.