New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script for updating files in the sample archive #481
Add a script for updating files in the sample archive #481
Conversation
917cc31
to
5a51a8a
Compare
@natiiix I think it would be good to mention it in the README. WDYT? And what about some |
# The first argument is used switch between returning a list of files and a list of unique directories containing said files. | ||
find_jsons() { | ||
if [ -z "$CONTENT_FILTER" ]; then | ||
# find "$SOURCE_PREFIX" -iname "*.json" | grep -oP "^${SOURCE_PREFIX_ESCAPED}\K[^:]+${1})" | sort | uniq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to not keep commented out code ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I generally agree with that, in this case, the commented out code performs a different task than the line below it. I didn't want to add a special switch for it because it would make the code even more unnecessarily complicated, but if you wanted to generated the sample archive completely without having an existing one, you would want to do it using that line of code. Perhaps it would be best to add a comment describing the difference as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be nice to add some flag argument enabling this option, but it doesn't have to be part of this PR.
Just tested, seems to work fine, but +1 for having an instruction in README or somewhere |
5a51a8a
to
1d94a50
Compare
1d94a50
to
7ce2c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix, Sergey1011010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This PR adds a shell script for updating the sample archive using an extracted IO archive gathered from an OCP cluster. Additional filtering can be applied in order to only updated certain files (based on their content). This was motivated by the sample archive update after the removal of
managedFields
from resource JSONs.Categories
Sample Archive
N/A
Documentation
N/A
Unit Tests
N/A
Privacy
Yes. There are no sensitive data in the newly collected information.
This PR doesn't add or modify any gathered data.
Changelog
No.
Breaking Changes
No.
References
https://issues.redhat.com/browse/CCXDEV-5281