Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2073945: Remove PSP gatherer #608

Merged
merged 1 commit into from Apr 14, 2022
Merged

Bug 2073945: Remove PSP gatherer #608

merged 1 commit into from Apr 14, 2022

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Apr 11, 2022

This removes the PSP gatherer, which requires PodSecurityPolicies with version v1beta1. This was removed and thus the alert APIRemovedInNextEUSReleaseInUse is firing.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

Removing docs/insights-archive-sample/config/psp_names.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=2073945
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2022

@tremes: This pull request references Bugzilla bug 2073945, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2073945: Remove PSP gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@tremes
Copy link
Contributor Author

tremes commented Apr 12, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

@tremes: This pull request references Bugzilla bug 2073945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula April 12, 2022 06:08
Serhii1011010
Serhii1011010 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@Serhii1011010 Serhii1011010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Haven't tested, but the change is very simple, CI will make sure nothing is broken.

natiiix
natiiix approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already had a testing cluter available, so I built it an let it generate an archive, and there was a non-empty archive, so I think it's fine.

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,natiiix,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Serhii1011010
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2fe1857 into openshift:master Apr 14, 2022
7 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 2073945 has been moved to the MODIFIED state.

In response to this:

Bug 2073945: Remove PSP gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Apr 28, 2022
@tremes
[release-4.10] Bug 2079318: Remove PSP gatherer (openshift#608)
cbae719
@tremes tremes deleted the remove_psp_gatherer branch April 28, 2022 07:29
@openshift-ci openshift-ci bot mentioned this pull request Apr 28, 2022
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request May 2, 2022
@tremes
[release-4.10] Bug 2079318: Remove PSP gatherer (#608) (#615)
5a15ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serhii1011010 Serhii1011010 Serhii1011010 approved these changes

@natiiix natiiix natiiix approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@tisnik tisnik Awaiting requested review from tisnik

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@Serhii1011010 Serhii1011010

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tremes @Serhii1011010 @openshift-bot @natiiix @openshift-merge-robot